New check: allah_ligature #4728
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
khaledhosny
reviewed
May 17, 2024
| """Ensure correct formation of allah ligature in the presence of tashkeel marks.""" | ||
|
|
||
| cmap = ttFont["cmap"].getBestCmap() | ||
| allah_unicode = 0xFDF2 |
There was a problem hiding this comment.
A font can contain الله or even لله ligature without U+FDF2 to it. It might also include U+FDF2 but use a different glyph for the ligature.
There was a problem hiding this comment.
Got it, thanks. Give me some time... This check is generally a bit immature still.
felipesanches
force-pushed
the
new-check-allah
branch
from
336f665
to
a27f84d
Compare
|
I've just rebased to current main branch and fixed the conflicts in this PR. |
felipesanches
force-pushed
the
new-check-allah
branch
from
a27f84d
to
2714819
Compare
Added to the Universal profile. allah_ligature: "Check correct formation of allah ligature in presence of explicit tashkeel." (issue #4727)
felipesanches
force-pushed
the
new-check-allah
branch
from
2714819
to
612e6ba
Compare
|
I've git-rebased this PR and fixed conflicts. |
|
I feel this may make more sense as a shaperglot check. |
|
If you can, please try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check correct formation of allah ligature in presence of explicit tashkeel (issue #4727)
Checklist
CHANGELOG.md