Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-12514054 Update device support and identification logic. #3819

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

Crebs
Copy link
Contributor

@Crebs Crebs commented Jan 28, 2025

This PR updates the device identification logic to include support for newly released devices and refines existing mappings. Key changes include:
• Added identification support for the latest iPhone and iPad models
• General code cleanup.

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0.38760% with 257 lines in your changes missing coverage. Please review.

Project coverage is 61.91%. Comparing base (34ce7f8) to head (9cce13a).
Report is 36 commits behind head on dev.

Files with missing lines Patch % Lines
...sforceSDKCore/Classes/Common/UIDevice+SFHardware.m 0.48% 206 Missing ⚠️
...sforceSDKCore/Classes/Common/UIDevice+SFHardware.h 0.00% 51 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3819      +/-   ##
==========================================
- Coverage   62.00%   61.91%   -0.10%     
==========================================
  Files         233      233              
  Lines       21654    21768     +114     
==========================================
+ Hits        13427    13478      +51     
- Misses       8227     8290      +63     
Components Coverage Δ
Analytics 81.88% <ø> (-1.26%) ⬇️
Common 68.87% <ø> (+0.08%) ⬆️
Core 50.57% <21.79%> (-0.07%) ⬇️
SmartStore 73.70% <ø> (+<0.01%) ⬆️
MobileSync 87.58% <ø> (ø)
Files with missing lines Coverage Δ
...sforceSDKCore/Classes/Common/UIDevice+SFHardware.h 0.00% <0.00%> (ø)
...sforceSDKCore/Classes/Common/UIDevice+SFHardware.m 5.11% <0.48%> (-0.55%) ⬇️

... and 9 files with indirect coverage changes

Copy link
Member

@bbirman bbirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for getting all this updated!

@Crebs Crebs merged commit 98dcd4a into forcedotcom:dev Jan 30, 2025
5 of 7 checks passed
@Crebs Crebs deleted the @W-12514054 branch January 30, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants