Fix Github Actions issues. #3822
Conversation
| warn("Big PR, try to keep changes smaller if you can.", sticky: true) if git.lines_of_code > 1000 | ||
|
|
||
| # Redirect contributors to PR to dev. | ||
| fail("Please re-submit this PR to the dev branch, we may have already fixed your issue.", sticky: true) if github.branch_for_base != "dev" |
There was a problem hiding this comment.
Does the whole check fail? Wondering about when we do PRs to master for cherry picks
There was a problem hiding this comment.
I believe it only fails the Danger status check on the PR. It should not stop the execution of tests or do much of anything else negative.
However, while writing this comment I realized it is actually completely pointless with the current configuration since CI is only triggered on dev. So I think we have two choices:
- Add
masteras a branch to trigger PRs. We probably want to keep the line then and ignore the fail. (Although I thought we typically just merge dev to master without a PR?). - Remove the warning since CI doesn't run against
master.
I think I like option # 1 more?
There was a problem hiding this comment.
sounds good! it's been a while but this was the scenario I was thinking of #3686
There was a problem hiding this comment.
I double checked this on the Android testing setup. It just displays this error, which is fine in the rare event we are cherry picking to master.
pull_request_targetmakes the default checkout ref the base branch instead of PR code.workflow_dispatchtrigger so nightly tests can be run from the browser.