Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React router v7 transition to react-router-devtools #151

Merged
merged 40 commits into from
Nov 22, 2024
Merged

React router v7 transition to react-router-devtools #151

merged 40 commits into from
Nov 22, 2024

Conversation

AlemTuzlak
Copy link
Contributor

Description

Start of the transition to react router v7 devtools from remix dev tools
image

Fixes # (issue)

If this is a new feature please add a description of what was added and why below:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

pkg-pr-new bot commented Oct 5, 2024

Open in Stackblitz

yarn add https://pkg.pr.new/forge42dev/Remix-Dev-Tools/[email protected]

commit: a46ba60

Copy link

github-actions bot commented Oct 5, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 84.78% (🎯 70%) 1098 / 1295
🟢 Statements 84.78% (🎯 70%) 1098 / 1295
🟢 Functions 89.53% (🎯 70%) 77 / 86
🟢 Branches 78.9% (🎯 75%) 273 / 346
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/client/hof.ts 81.35% 100% 100% 81.35% 26-36
src/client/context/RDTContext.tsx 95.52% 66.66% 85.71% 95.52% 54-55, 59
src/client/context/rdtReducer.ts 92.38% 87.5% 100% 92.38% 318-321, 323-326, 328-331, 348-351
src/client/hooks/detached/useRemoveBody.ts 50% 66.66% 100% 50% 11-18
src/client/utils/detached.ts 100% 100% 100% 100%
src/client/utils/routing.ts 44.44% 87.5% 50% 44.44% 20-21, 32-33, 48-56, 63-76, 79-93
src/client/utils/sanitize.ts 41.37% 91.66% 50% 41.37% 25-36, 43-44, 55-75, 78-79
src/client/utils/storage.ts 84% 75% 100% 84% 6-7, 14-15
src/server/config.ts 100% 50% 50% 100%
src/server/hof.ts 100% 100% 100% 100%
src/server/logger.ts 88.57% 83.33% 100% 88.57% 29-30, 39-40
src/server/perf.ts 100% 86.36% 100% 100%
src/server/utils.ts 89.15% 83.96% 100% 89.15% 111, 113, 155-156, 198-199, 241-242, 246-256, 280-290, 318-319
src/shared/send-event.ts 27.77% 33.33% 100% 27.77% 5-6, 10-21
src/vite/utils/babel.ts 77.77% 0% 100% 77.77% 12, 17
src/vite/utils/data-functions-augment.ts 91.54% 68.57% 100% 91.54% 17-18, 26-27, 83-84, 87-88, 150-151, 154-155
src/vite/utils/inject-client.ts 97.08% 73.07% 100% 97.08% 42, 114-115
src/vite/utils/inject-context.ts 91.52% 56.52% 100% 91.52% 16-17, 70-71, 74-75, 128-129, 132-133
Generated in workflow #68 for commit 64dfbc1 by the Vitest Coverage Report Action

@AlemTuzlak AlemTuzlak mentioned this pull request Oct 5, 2024
@AlemTuzlak AlemTuzlak changed the title Start of React router v7 transition React router v7 transition to react-router-devtools Nov 8, 2024
@AlemTuzlak AlemTuzlak merged commit 5611898 into main Nov 22, 2024
5 of 6 checks passed
@AlemTuzlak AlemTuzlak deleted the rr7 branch November 22, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants