Add async support for DTLS #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors cancel |
1 similar comment
|
bors cancel |
jethrogb
reviewed
Apr 20, 2023
| async fn send(&mut self, buf: &[u8]) -> IoResult<usize> { | ||
| self.io_mut() | ||
| .ok_or(IoError::new(IoErrorKind::Other, "stream has been shutdown"))? | ||
| .send(buf) |
There was a problem hiding this comment.
How does MbedTLS buffering work in DTLS?
jethrogb
reviewed
Apr 20, 2023
| // Could implement by using `async-trait` crate or | ||
| // #![feature(async_fn_in_trait)] or Associated Types | ||
| async fn send(&mut self, buf: &[u8]) -> IoResult<usize> { | ||
| self.io_mut() |
There was a problem hiding this comment.
This doesn't seem correct? You need to call mbedtls_ssl_write here. Same issue for recv. I think you can avoid async-trait and some headache if you model this with fn poll_recv and fn poll_send instead of async fn.
|
This old PR need to rebase on to |
|
Close this, since it's no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep things simple, the async support for DTLS is implemented by:
ConnectedAsyncUdpSocketAsyncReadandAsyncWriteforConnectedAsyncUdpSocketasync-sessiontest for testing DTLS