-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessors in vendor code to replace private_
fields access
#279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added conditional compilation flags "MBEDTLS_FORCE_AESNI" and "MBEDTLS_FORCE_PADLOCK" 2. This allows us to supress cpuid based feature detection on sgx platforms. 3. "MBEDTLS_FORCE_AESNI" gets set if "force_aesni_support" flag is enabled. 4. Please refer to the previous commit for rust side changes.
- better renaming through `item_name` - remove unnecessary comments for default value of DEFINE's - add bindgen for static inline functions - add LTO for generated static inline functions
- Remove and add self_test for mbedtls 3.4.0 - Remove deprecated features
update src - revert unnessary format changes - add `SslStates` - add special case handling in `Read` and `AsyncRead` - update code to sync with new C mbedtls API - some fields become private and renamed with prefix: `private_` - some functions need RNG now: - Pk::from_private_key - Pk::private_from_ec_components - add `mbedtls_psa_external_get_random` update tests - add `hyper_async` test for testing async and hyper14 - update old tests code to sync with new C mbedtls API - revert unnessary format changes
ci: refacor ci - Use `nextest` to run tests - Refactor travis config - Put arm job run on arm vm instead of using not use qemu
Remove usage of `generate_deprecated_union_accessors`
Since bindings of psa related code has been put in a mod: psa, mbedtls side code need to be updated to sync with new code structure.
Set `MBEDTLS_CONFIG_VERSION` to number for 3.4.0
- move MBEDTLS_PKCS12_C behind the feature `pkcs12` - put pkcs12.h behind the feature `pkcs12`
Replace access to private_mode by using accessor
Use a better version value for `mbedtls-sys-auto`
This reverts commit 446b9b0.
Upgrade to c-mbedtls commit: `0b3de6fce`, where: - pull request #7288 is merged - #7288: TLS: TLS 1.2 / 1.3 version negotiation on server side Signed-off-by: Yuxiang Cao <[email protected]>
Replaced access to private fields by using new accessors.
Taowyoo
force-pushed
the
yx/upgrade-mbedtls
branch
7 times, most recently
from
June 15, 2023 23:25
136c991
to
d054c6c
Compare
Taowyoo
force-pushed
the
yx/upgrade-mbedtls
branch
5 times, most recently
from
June 23, 2023 21:59
5020a42
to
f028d00
Compare
Taowyoo
force-pushed
the
yx/upgrade-mbedtls
branch
3 times, most recently
from
June 26, 2023 23:11
78090be
to
7a1e697
Compare
This PR is too old, will create a another new PR for #283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://github.com/fortanix/rust-mbedtls/blob/f92979a91102fd3e743decee1c0ecfd55b3d29dd/mbedtls-sys/vendor/docs/3.0-migration-guide.md
We need to prevent accessing to any field with prefix:
private_
, so in this PR, a lot of accessors have been added to vendor code to achieve this.All vendor code also need to be up-streamed