-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builds and add CI check for no-std targets #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR LGTM.
But could you provide the build command that could reproduce the error.
If possible, need to add a build check on this in CI to avoid same problem in future
That sounds like a great idea! I will try to add a corresponding build target in the CI when I find some time to work on that. |
65c2c3b
to
9665d52
Compare
…d succeed without std support
9665d52
to
74eeb22
Compare
… time feature is no active
3d06edc
to
5b949ee
Compare
dbcd916
to
bc0f3c4
Compare
Fixing no_std support apparently requires more than I first anticipated. The current state is not safe to merge because many types |
Close this old PR because of change of default branch to Please reopen this if have further problems or you rebased this PR onto |
The current
master
does not build forno_std
targets becausembedtls-platform-supports
usesonce_cell::sync::OnceCell
, theonce_cell::sync
module ist only available if thestd
feature is active foronce_cell
. Thus, the currentmaster
only builds forstd
targets.This PR fixes this, but only if the
tls13
feature is not active. (Edit: Not true anymore thanks to thecritical-section
feature inonce_cell
)