Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendored mbedtls to v2.28.9 #374

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Update vendored mbedtls to v2.28.9 #374

merged 4 commits into from
Jan 2, 2025

Conversation

s-arash
Copy link
Collaborator

@s-arash s-arash commented Dec 23, 2024 •
edited
Loading

Updated the vendored mbedtls by running ./upgrade_vendor.sh v2.28.9.

Arash Sahebolamri and others added 4 commits December 23, 2024 13:37
Vendor Change: upgrade mbedtls to v2.28.9
0ff1f78
Vendor Change:-
ef4e8b9 
1. Added conditional compilation flags "MBEDTLS_FORCE_AESNI" and "MBEDTLS_FORCE_PADLOCK"
2. This allows us to supress cpuid based feature detection on sgx platforms.
3. "MBEDTLS_FORCE_AESNI" gets set if "force_aesni_support" flag is enabled.
4. Please refer to the previous commit for rust side changes.

(cherry picked from commit d2317b0)
@raoulstrackx
Adding mpi_force_c_code feature
96a2e3a 
(cherry picked from commit 38522c2)
Bump mbedtls-sys version to 2.28.9 to match vendored mbedtls
068560b
@s-arash s-arash marked this pull request as ready for review December 23, 2024 22:08
@Taowyoo
Copy link
Collaborator

Taowyoo commented Dec 24, 2024

PR lgtm,
Are we not going to use submodule ?

@s-arash
Copy link
Collaborator Author

s-arash commented Dec 24, 2024

PR lgtm, Are we not going to use submodule ?

Thanks. That may be a more controversial change. I opened this as a backup in case that one does not get approved.

@Taowyoo Taowyoo merged commit 2a962b0 into fortanix:master Jan 2, 2025
11 checks passed
@jethrogb
Copy link
Member

jethrogb commented Jan 6, 2025

It's not clear to me you did the following steps outlined in the README:

  • Use the command in build/headers.rs to generate the list of headers, and update that file as appropriate.
  • Check build/config.rs vs. vendor/include/mbedtls/config.h.

@s-arash
Copy link
Collaborator Author

s-arash commented Jan 6, 2025

Thanks @jethrogb for reminding me. I went through the steps, the only thing missing was a new config MBEDTLS_PSA_ASSUME_EXCLUSIVE_BUFFERS. I opened a PR to add it to config.rs: #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taowyoo Taowyoo Taowyoo approved these changes

@MihirLuthra MihirLuthra Awaiting requested review from MihirLuthra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s-arash @Taowyoo @jethrogb @raoulstrackx