Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SALM-572 Update converter API to include CCM/DSM configs #19

Merged
merged 3 commits into from
Dec 5, 2024
Merged

SALM-572 Update converter API to include CCM/DSM configs #19

merged 3 commits into from
Dec 5, 2024

Conversation

aditijannu
Copy link
Collaborator

  • Converter API is updated to include two additional converter options which specify the endpoint for nitro enclaves to connect to while requesting app configs and encryption keys
    • ccm_configuration
    • dsm_configuration
  • Also ensure skip_server_verify and fs_api_key environment variables are only used in enclaves converted with the debug converter option

nshyrei
nshyrei previously requested changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@nshyrei nshyrei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some files there is a sign of a missing newline, can you fix that please?
image

@aditijannu
Copy link
Collaborator Author

For some files there is a sign of a missing newline, can you fix that please? image

Cargo fmt changes my PR quiet a bit, I'd like to do a cargo fmt at the end once review is complete. I also created RTE-267 to deal with this issue.

raoulstrackx
raoulstrackx reviewed Nov 29, 2024
View reviewed changes
tools/container-converter/src/image_builder/enclave.rs Outdated Show resolved Hide resolved
vsock-proxy/enclave/src/dsm_key_config.rs Outdated Show resolved Hide resolved
vsock-proxy/enclave/src/file_system.rs Outdated Show resolved Hide resolved
api-model/src/converter.rs Show resolved Hide resolved
api-model/src/converter.rs Show resolved Hide resolved
@aditijannu aditijannu requested a review from nshyrei December 5, 2024 11:10
@aditijannu aditijannu dismissed nshyrei’s stale review December 5, 2024 11:12

Already addressed review changes and nikita is on vacation this week. Moving forward with the merge.

@aditijannu aditijannu added this pull request to the merge queue Dec 5, 2024
Merged via the queue into master with commit 53824d9 Dec 5, 2024
1 check passed
@aditijannu aditijannu deleted the aj/SALM-572 branch December 5, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raoulstrackx raoulstrackx raoulstrackx approved these changes

@nshyrei nshyrei Awaiting requested review from nshyrei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditijannu @nshyrei @raoulstrackx