Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter "_" env var #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Filter "_" env var #25

wants to merge 2 commits into from

Conversation

nshyrei
Copy link
Contributor

@nshyrei nshyrei commented Jan 10, 2025

Filters the "_" env variable list that is sent to the enclave by the parent before starting the client application. The "_" variable holds the last argument of the previous command according to: https://unix.stackexchange.com/questions/436615/when-is-an-environment-variable-of-a-bash-shell. This information is not particularly necessary for the enclave and potentially can be a security risk, thus it's a good idea to filter it out.

@nshyrei nshyrei added the enhancement New feature or request label Jan 10, 2025
@nshyrei nshyrei self-assigned this Jan 10, 2025
@jethrogb
Copy link
Member

_ should be set to what it would be set to if you were running your container without salmiac.

vsock-proxy/parent/src/parent.rs Outdated Show resolved Hide resolved
vsock-proxy/parent/src/parent.rs Outdated Show resolved Hide resolved
@nshyrei nshyrei requested a review from aditijannu January 22, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants