[DEVOPS-5457] Upgrade dependencies version #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `loopdev` feature on crate sys-mount to avoid dependency on old version of bindgen. This helps fixing the bindgen vs clang inconpatibility issue. Because we use `sys-mount` only for mount ext4 filesystem, there is no usaage of mounting loop device, this change is safe.
Taowyoo
requested review from
nshyrei,
aditijannu,
raoulstrackx,
Adit-Shah-ftx and
achairesaguirre
|
The converter does use loop mounts at conversion time to create and populate block devices, so I'm not sure if it's okay to remove the loopdev feature. I would like to do a CI run or QA validation on this branch before we merge it. |
|
@aditijannu Thanks for telling me this. |
This reverts commit 52b2d0a.
Upgrade sys-mount version to latest and corresponding tar version. `tar` version needs to upgraded to at least 0.4.39 to include original git based version, see: alexcrichton/tar-rs@f4f439c
|
@Taowyoo Please update the title of your PR according to the new changes. |
Taowyoo
changed the title
dlegalov-fortanix
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
sys-mountandtarversion to avoid dependency on old version of bindgen.This helps fixing the bindgen vs clang incompatibility issue. See details in internal Jira ticket DEVOPS-5457.