Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nvidia-hpc and lfortran versions #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gha3mi
Copy link
Contributor

@gha3mi gha3mi commented May 26, 2024

Hi

This PR updates the nvidia-hpc and lfortran versions to the latest.

Thanks
Ali

@wpbonelli
Copy link
Contributor

Thanks @gha3mi can you update the CSVs and README?

Also need to make sure this doesn't push the CI test workflow over the 256 job limit. I think for Intel we want to exhaustively catalog and test since the installation process is more difficult, but for the rest we can do a sliding window and support older versions implicitly

@gha3mi
Copy link
Contributor Author

gha3mi commented Jun 6, 2024

can you update the CSVs and README?

Sure, but should the CSVs be updated manually or will they be updated automatically through the .github/workflows/test.yml?

Also need to make sure this doesn't push the CI test workflow over the 256 job limit. I think for Intel we want to exhaustively catalog and test since the installation process is more difficult, but for the rest we can do a sliding window and support older versions implicitly

For nvidia, we could test only the latest version and the latest version from each year.

  • Latest: 24.5
  • Latest from 2023: 23.11
  • Latest from 2022: 22.11
  • Latest from 2021: 21.11
  • Latest from 2020: 20.11

For lfortran, we could support only the latest version until it reaches the beta stage.

@wpbonelli
Copy link
Contributor

For nvidia, we could test only the latest version and the latest version from each year. For lfortran, we could support only the latest version until it reaches the beta stage.

Sounds good to me

Sure, but should the CSVs be updated manually or will they be updated automatically through the .github/workflows/test.yml?

The workflow auto-updates them only in report mode (scheduled run or manual trigger), when this is merged it runs in test mode. We can do a manual run after merge but it saves some cycles to update them in the PR. The reporting mode is mainly meant to alert us and auto-update when runner images shift underfoot. Not sure this is the best way of setting things up.

@wpbonelli
Copy link
Contributor

@gha3mi can you update CSVs/README when you have a chance? then this could merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants