fix: pr feedback

forwardemail · Oct 3, 2024 · 8802219 · 8802219
1 parent 1113b2f
commit 8802219
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/app/models/domains.js b/app/models/domains.js
@@ -367,7 +367,11 @@ const Domains = new mongoose.Schema({
     default: '25',
     validator: (value) => isPort(value)
   },
-  alias_count: { type: Number },
+  alias_count: { 
+    type: Number,
+    min: 0,
+    index: true
+  },
   members: [Member],
   invites: [Invite],
   name: {

diff --git a/app/models/users.js b/app/models/users.js
@@ -274,6 +274,7 @@ object[config.userFields.defaultDomain] = {
 
 object[config.userFields.domainCount] = {
   type: Number,
+  min: 0,
   index: true
 };
 

diff --git a/app/views/admin/domains/_table.pug b/app/views/admin/domains/_table.pug
@@ -11,7 +11,7 @@ include ../../_pagination
           +sortHeader('is_global', 'Global', '#table-domains')
         th.align-middle(scope="col")= t("Members")
         th(scope="col")
-          +sortHeader('aliases', 'Aliases', '#table-domains')
+          +sortHeader('alias_count', 'Aliases', '#table-domains')
         th(scope="col")
           +sortHeader('plan', 'Plan', '#table-domains')
         th(scope="col")

diff --git a/app/views/admin/users/_table.pug b/app/views/admin/users/_table.pug
@@ -12,7 +12,7 @@ include ../../_pagination
         th(scope="col")
           +sortHeader('email', null, '#table-users')
         th(scope="col")
-          +sortHeader('domains', null, '#table-users')
+          +sortHeader('domain_count', 'Domains', '#table-users')
         th(scope="col")
           +sortHeader('plan', null, '#table-users')
         th(scope="col")
-Original file line number
+Diff line change
@@ Expand Up / @@ -274,6 +274,7 @@ object[config.userFields.defaultDomain] = { @@
     object[config.userFields.domainCount] = {
       type: Number,
+      min: 0,
       index: true
     };
@@ Expand Down @@