Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing client when request is removed . #560

Merged
merged 5 commits into from
Feb 15, 2025
Merged

Closing client when request is removed . #560

merged 5 commits into from
Feb 15, 2025

Conversation

Clasherzz
Copy link
Contributor

PR Description

The client is terminated when request is removed

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I am using the latest Flutter stable branch (run flutter upgrade and verify)
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

  • No, and this is why: Looked at test file of collection provider and didn't saw code related to this function.

OS on which you have developed and tested the feature?

  • Windows
  • macOS
  • Linux

@Clasherzz Clasherzz marked this pull request as draft February 9, 2025 15:48
@ashitaprasad ashitaprasad marked this pull request as ready for review February 9, 2025 22:54
@ashitaprasad ashitaprasad merged commit c69c937 into foss42:main Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client not stopping even after it gets removed.
2 participants
@Clasherzz @ashitaprasad