-
Notifications
You must be signed in to change notification settings - Fork 82
readme update #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
readme update #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vedansh Saini <[email protected]>
Reviewer's GuideThis PR refreshes the project README by disabling the Firefox setup section and adding updated extension UI screenshots, and it toggles off debug logging in the Scrum Helper script. Class diagram for debug logging toggle in Scrum HelperclassDiagram
class ScrumHelper {
+allIncluded(outputTarget)
-DEBUG : boolean
+log(...args)
}
ScrumHelper : DEBUG = false (was true)
ScrumHelper : log() only logs if DEBUG is true
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedansh-5 - I've reviewed your changes - here's some feedback:
- Instead of hardcoding DEBUG as a boolean, consider using an environment variable or config option to toggle logging without modifying source code.
- Since the Firefox setup section is no longer needed, you might remove the commented-out block entirely rather than keep it wrapped in HTML comments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of hardcoding DEBUG as a boolean, consider using an environment variable or config option to toggle logging without modifying source code.
- Since the Firefox setup section is no longer needed, you might remove the commented-out block entirely rather than keep it wrapped in HTML comments.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
hpdang
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Fixes
Fixes #145
📝 Summary of Changes
Updated images of extensions' UI, commented out the firefox setup part.
📸 Screenshots / Demo (if UI-related)
Add screenshots, video, or link to deployed preview if applicable
✅ Checklist
👀 Reviewer Notes
Add any special notes for the reviewer here
Summary by Sourcery
Update documentation images and instructions, and disable debug logging in the codebase.
Enhancements:
Documentation: