Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to cancel and change language due to overflow in search on smaller screens #3598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Harshchourasiya
Copy link

@Harshchourasiya Harshchourasiya commented Sep 7, 2020

Not able to cancel and change language due to overflow in search on smaller screens #3596

Changes: User can select any options and can also use cancel and change language options

Demo Link : https://pr-3598-fossasia-susi-web-chat.surge.sh/

Screenshots of the change:

**Before : **

SusiIssuError

**After : **

IssusSolve

@Harshchourasiya Harshchourasiya changed the title Small Screen option issus Not able to cancel and change language due to overflow in search on smaller screens Sep 7, 2020
Copy link
Member

@Raunaksingh100 Raunaksingh100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo link is not working

@Harshchourasiya
Copy link
Author

Demo link is not working

Hey bro, I am New in open source and this is my first pull request So i don't Understand How to get Link Can you please Guide me?

@snitin315
Copy link
Member

@Harshchourasiya
Copy link
Author

It should be

https://pr-3598-fossasia-susi-web-chat.surge.sh/

Yes, its work Thanks

@elit-altum
Copy link
Member

The dialogue box is still not visible on the screen immediately after resizing its only after the filters are changed that the dialogue box appears
image

This is the case as the site renders completely differently on smaller screens and what we are doing now is viewing the larger screen version on smaller screens. Please refresh after opening the webpage in the inspector to see the changes.

Copy link
Member

@Dilshaad21 Dilshaad21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR #3604 solving the same issue is already being made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants