Skip to content

feat(cast): add flag to disable alias #10924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 7, 2025
Merged

feat(cast): add flag to disable alias #10924

merged 5 commits into from
Jul 7, 2025

Conversation

varun-doshi
Copy link
Contributor

Motivation

Fixes #10848

Solution

  • Add optional cli flag to CallArgs that is bound to trace
  • modify CallTraceDecoderBuilder and CallTraceDecoder to handle the flag
  • Add test

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

zerosnacks
zerosnacks reviewed Jul 4, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, some suggestions

@varun-doshi varun-doshi requested a review from zerosnacks July 4, 2025 09:41
DaniPopes
DaniPopes reviewed Jul 4, 2025
View reviewed changes
@varun-doshi varun-doshi requested a review from DaniPopes July 4, 2025 14:55
0xrusowsky
0xrusowsky requested changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, the rest lgtm

0xrusowsky
0xrusowsky requested changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, the rest lgtm

@0xrusowsky
Copy link
Contributor

@varun-doshi you also need to run cargo fmt

@varun-doshi varun-doshi requested a review from 0xrusowsky July 7, 2025 10:39
@grandizzy grandizzy changed the title feat: add flag to disable alias feat(cast): add flag to disable alias Jul 7, 2025
grandizzy
grandizzy approved these changes Jul 7, 2025
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, lgtm!

@grandizzy grandizzy enabled auto-merge (squash) July 7, 2025 11:03
@grandizzy grandizzy merged commit e01b956 into foundry-rs:master Jul 7, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Jul 7, 2025
@grandizzy grandizzy mentioned this pull request Jul 9, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grandizzy grandizzy grandizzy approved these changes

@0xrusowsky 0xrusowsky 0xrusowsky approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a flag to disable contract alias on transaction traces
5 participants
@varun-doshi @0xrusowsky @grandizzy @DaniPopes @zerosnacks