refactor: deploy all libraries when running tests #8034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Jun 2, 2024
|
This should close #8014 |
DaniPopes
reviewed
Jun 2, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1161
Closes #6120
Closes #8014
Keeping foundry-rs/book#1361 open as this still won't work in scripts.
Solution
Instead of linking each contract separately and keeping separate
libs_to_deployfor each test contract we now link entire project output and keep singlelibs_to_deployandknown_contracts. That way, we reduce memory usage and by deploying all needed libraries unblock usage ofgetCode/getDeployedCodewith artifacts requiring linking.To avoid nonce of the
senderbeing affected by the number of external libraries used in project, I've inroduced separateLIBRARY_DEPLOYERwhich deploys all libraries, that way, test contract will always have the same address regardless of the number of libraries it requires to run.