Skip to content

Commit

Permalink
client: actually stream messages in iter_messages
Browse files Browse the repository at this point in the history
  • Loading branch information
james-rms committed Oct 24, 2024
1 parent e464e3e commit 55901a4
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions foxglove/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,13 @@ def get_messages(
reader = make_reader(BytesIO(data), decoder_factories=decoder_factories)
return [
(channel.topic, message, decoded_message)
for _, channel, message, decoded_message in reader.iter_decoded_messages()
for _, channel, message, decoded_message in reader.iter_decoded_messages(
topics=None,
start_time=None,
end_time=None,
log_time_order=False,
reverse=False,
)
]

def iter_messages(
Expand Down Expand Up @@ -355,7 +361,13 @@ def iter_messages(
# We deep-copy here as these factories might be mutated
decoder_factories = copy.deepcopy(DEFAULT_DECODER_FACTORIES)
reader = make_reader(response.raw, decoder_factories=decoder_factories)
return reader.iter_decoded_messages()
return reader.iter_decoded_messages(
topics=None,
start_time=None,
end_time=None,
log_time_order=False,
reverse=False,
)

def download_recording_data(
self,
Expand Down

0 comments on commit 55901a4

Please sign in to comment.