Update "fetching_messages" example #115
Conversation
| @@ -9,7 +9,7 @@ on: | |||
|
|
|||
| jobs: | |||
| python: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-22.04 | |||
There was a problem hiding this comment.
Staying on 22 for now to avoid build errors: https://github.com/foxglove/foxglove-python/actions/runs/12356809802/job/34535840957. Runners have been rolling out 24.04 as "latest" this month.
| @@ -9,10 +9,9 @@ | |||
|
|
|||
| # Make sure you've imported either the mcap-ros1-support or mcap-protobuf-support | |||
| # libraries before making this call in order to get decoded messages. | |||
| messages = client.get_messages( | |||
| for schema, channel, message, decoded_message in client.iter_messages( | |||
There was a problem hiding this comment.
Should we do anything with decoded_message in this example?
There was a problem hiding this comment.
I started to, but doing anything useful seemed dependent on the data and implementation (per comment above). I could prefix with an underscore to indicate it's unused?
There was a problem hiding this comment.
Makes sense. I think it's fine to leave it as is to show it's there
examples/fetching_messages.py
Outdated
|
|
||
| print(f"downloaded {len(messages)} messages") | ||
| ): | ||
| print(f"[{message.log_time}] Channel: {channel.topic} Schema: {schema.name}") |
There was a problem hiding this comment.
nit: formatting of the labels feels a bit hard to read for me:
[1479512770391847576] Channel: /imu/data Schema: sensor_msgs/Imu
[1479512770391861165] Channel: /time_reference Schema: sensor_msgs/TimeReference
[1479512770391922289] Channel: /time_reference Schema: sensor_msgs/TimeReference
[1479512770391937993] Channel: /pressure Schema: sensor_msgs/FluidPressure
Maybe something simpler?
| print(f"[{message.log_time}] Channel: {channel.topic} Schema: {schema.name}") | |
| print(f"{message.log_time} | {channel.topic} \t| {schema.name}") |
i.e.
1479512810369905916 | /fix | sensor_msgs/NavSatFix
1479512810369936841 | /ecef/ | geometry_msgs/PointStamped
1479512810370480491 | /time_reference | sensor_msgs/TimeReference
1479512810370530865 | /time_reference | sensor_msgs/TimeReference
1479512810370682589 | /imu/data | sensor_msgs/Imu
1479512810370709498 | /time_reference | sensor_msgs/TimeReference
1479512810370745760 | /fix | sensor_msgs/NavSatFix
Thanks; CI now lints the examples as well. |
bryfox
deleted the
bryan/fg-9176-fetching_messagespy-example-uses-deprecated-method
branch
Changelog
None
Docs
None
Description
This updates the "fetching_messages" example to remove a deprecated method call in favor of the streaming
iter_messages. Instead of printing the length, it prints the timestamp, channel, and topic of each message; for example: