Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FG-2933: Add microphone capture (opus) to MCAP recording demo #1293

Open
wants to merge 4 commits into
base: fgwt202412/audio-recorder
Choose a base branch
from

Conversation

fgwt202412
Copy link

@fgwt202412 fgwt202412 commented Dec 13, 2024

  1. FG-2933: Add recorder support for audio frames to MCAP recording demo #1292
  2. FG-2933: Add microphone capture (opus) to MCAP recording demo #1293 <-- you are here
  3. FG-2933: Add mp4a.40.2 capture to MCAP recording demo #1295

Changelog

Add microphone capture (opus) to MCAP recording demo

Docs

None

Description

Foxglove does not currently support audio messages of any kind. In order to support playback of audio in Foxglove Studio, this stack of PRs adds support to record MCAP files with audio.

This PR adds the ability for a user to select a microphone for capture.

  • Show a checkbox for Microphone (Opus) when supported
  • Show microphone volume level while microphone is enabled
  • Read, encode, and record the audio track when recording is enabled

Tested locally using the MCAP recording demo and a new Audio panel.

FG-2933

BeforeAfter
audio-capture-demo.mov
Screenshot 2024-12-15 at 4 41 32 PM

Copy link

linear bot commented Dec 13, 2024

@fgwt202412 fgwt202412 force-pushed the fgwt202412/audio-recorder branch from 02b405a to 5661220 Compare December 15, 2024 19:39
@fgwt202412 fgwt202412 force-pushed the fgwt202412/mcap-demo-audio branch from f3a0ec1 to ad01ad1 Compare December 15, 2024 20:02
@fgwt202412 fgwt202412 force-pushed the fgwt202412/audio-recorder branch from 36f7053 to 32a35ac Compare December 15, 2024 20:18
@fgwt202412 fgwt202412 force-pushed the fgwt202412/mcap-demo-audio branch 2 times, most recently from 797a186 to cc82911 Compare December 15, 2024 21:12
@fgwt202412 fgwt202412 force-pushed the fgwt202412/mcap-demo-audio branch from cc82911 to 7b6c7be Compare December 15, 2024 23:02
@fgwt202412 fgwt202412 marked this pull request as ready for review December 15, 2024 23:30
@fgwt202412 fgwt202412 force-pushed the fgwt202412/audio-recorder branch from 6fcd2d3 to cedca32 Compare December 16, 2024 18:48
@fgwt202412 fgwt202412 force-pushed the fgwt202412/mcap-demo-audio branch from 7b6c7be to c3755ca Compare December 16, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant