Add into_inner() on Rust writer #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust/src/write.rs
Outdated
| .finalize() | ||
| .0 | ||
| .finish() | ||
| .expect("compression error") |
There was a problem hiding this comment.
Did you mean to have this here instead of returning a result?
There was a problem hiding this comment.
Yes. It's because of the zstd compressor. I'll add a comment to clarify.
There was a problem hiding this comment.
what if we swallowed the error instead? The caller is already expecting to not get a complete MCAP.
There was a problem hiding this comment.
I've rejigged it to avoid the unwrap entirely by using the interface in zio::Writer instead.
There was a problem hiding this comment.
@james-rms swallowing wasn't an option because the wrapper interface wouldn't even let you get the W back unless finishing succeeded.
Muon
force-pushed
the
mak/rust-writer-into_inner
branch
from
6a19bdb to
d2cfc83
Compare
james-rms
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add an
into_inner()method on the Rust writer to get back the underlying stream.Docs
https://linear.app/foxglove/issue/FG-9969/[rust-sdk]-cant-close-mcap-writer
Description
Some I/O errors only show up when the output file is closed. This change allows users to check for such errors.
Fixes: FG-9969