Add relevant results & retain search query from previous page #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsens
reviewed
Feb 4, 2025
| const firstElementNamePart = this.element?.name.split(/(?=[A-Z])/)[0]; | ||
| this.searchQuery = firstElementNamePart ?? ''; | ||
| if (this.element) { | ||
| const firstElementNamePart = this.element.name.split(/(?=[A-Z])/)[0]; |
There was a problem hiding this comment.
Maybe also split on numbers? We have a lot of pipes with a '2' in them.
Might be nice to create a variable (or method) for this regex for readability.
|
When going back to home, shouldn't the filters also stay? |
|
This issue was specifically for retaining state while navigating through browser history, I could keep the searchquery and filters saved in the service and reuse them if they are available. |
philipsens
deleted the
issue/253-strange-behavior-to-the-left-menu-after-searching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.