fix: standardize focus outline style #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyenltnguyen
commented
Mar 26, 2024
Comment on lines
+100
to
+103
| @mixin focus-outline { | ||
| outline: 3px solid $--blue-50 $i; | ||
| outline-offset: 0 $i; | ||
| } |
There was a problem hiding this comment.
The styles are copied from /learn.
huyenltnguyen
commented
Mar 26, 2024
Comment on lines
+814
to
+818
| .topic-list .main-link { | ||
| &.focused { | ||
| box-shadow: none $i; /* Unset the default Discourse styles */ | ||
| } | ||
| } |
There was a problem hiding this comment.
Discourse adds a blue stripe to the left edge of a focused item. We don't need it as we want to use our own styles.
raisedadead
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)This PR sets a custom focus outline to the forum theme in order to make its display consistent across browsers.
Result
Note: The Categories button looks a little off, and I have #117 to address that separately.