fix: flat buttons #122
Merged
fix: flat buttons #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyenltnguyen
commented
Apr 18, 2024
| @@ -611,7 +611,7 @@ td.poster-names a { | |||
| } | |||
|
|
|||
| //buttons ---------------------------- | |||
| .btn, | |||
| .btn:not(.btn-flat), | |||
There was a problem hiding this comment.
Other icon-only buttons don't have the btn class, but the bookmark button does, so it's affected by this selector.
The fix is to exclude the btn-flat class from the selector as buttons with this class are less bright and don't have a border (which are what the btn class wants to change).
raisedadead
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes freeCodeCamp/freeCodeCamp#54356.
There are two issues in the ticket:
(1) was fixed by #121, and this PR addresses (2).
Screenshots