New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pad the search box evenly #127

Merged

raisedadead merged 1 commit into freeCodeCamp:main from huyenltnguyen:fix/search-button

Apr 23, 2024

Member

huyenltnguyen commented Apr 23, 2024

Checklist:

I have read freeCodeCamp's contribution guidelines.
My pull request has a descriptive title (not a vague title like Update index.md)

This PR:

Adds a right margin to the advanced search button so that the padding of the search box looks even
Replaces an $i flag that was added by fix: various issues #124 with class selector (I'm trying to avoid using the !important flag)

Screenshot

Before	After


          fix: pad the search box evenly

871ffda

huyenltnguyen requested a review from a team as a code owner

April 23, 2024 05:23

raisedadead approved these changes

View reviewed changes

raisedadead merged commit c067e95 into freeCodeCamp:main

1 check passed

huyenltnguyen deleted the fix/search-button branch

April 23, 2024 15:51

huyenltnguyen mentioned this pull request

The icons in the menu is not the correct contrast #126

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet