Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamically set curriculum href #130

Merged
merged 22 commits into from
May 24, 2024

Conversation

ShaunSHamilton
Copy link
Member

Closes: #101
Closes: freeCodeCamp/freeCodeCamp#40372

Note: This directs Campers to https://freecodecamp.org/<locale> NOT https://freecodecamp.org/<locale>/learn.

@ahmaxed
Copy link
Member

ahmaxed commented May 24, 2024

Thanks for the pr.
Deutsch should also map to https://www.freecodecamp.org/german/ ?

@ShaunSHamilton
Copy link
Member Author

@ahmaxed Thank you for catching that. I assumed we did not have German for /learn yet.

@ahmaxed
Copy link
Member

ahmaxed commented May 24, 2024

Not sure if we need chinese-traditional, but we could double check with the localization team and adjust the settings accordingly.

Thank you @erikasby and @ShaunSHamilton

@ahmaxed ahmaxed merged commit 8d1ce80 into freeCodeCamp:main May 24, 2024
1 check passed
@ShaunSHamilton ShaunSHamilton deleted the feat_nav branch May 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forum's curriculum nav item should link to relevant language of the curriculum
3 participants