New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple issues in link styles #131

Merged

raisedadead merged 3 commits into freeCodeCamp:main from huyenltnguyen:fix/link-styles

Jul 5, 2024

Member

huyenltnguyen commented Jul 5, 2024

Checklist:

I have read freeCodeCamp's contribution guidelines.
My pull request has a descriptive title (not a vague title like Update index.md)

This PR fixes the following issues:

Text color of active sidebar items not having sufficient contrast
Active link having a blue underline (this apparently came from a Discourse change. Having the underline isn't a big deal, but I think it's redundant)
Some link icons are in blue instead of using the link text color

Screenshots

Issue	Before	After
Sidebar item
Link underline
Link icon

huyenltnguyen added 3 commits

July 5, 2024 16:20


          fix: text color of active sidebar item

2f3fdc3


          fix: remove underline from active link

dc801b8


          fix: use the same text color in link icon

b52f1a6

huyenltnguyen marked this pull request as ready for review

July 5, 2024 09:45

huyenltnguyen requested a review from a team as a code owner

July 5, 2024 09:45

raisedadead approved these changes

View reviewed changes

raisedadead merged commit a6f5fe4 into freeCodeCamp:main

1 check passed

huyenltnguyen deleted the fix/link-styles branch

July 5, 2024 15:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet