Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scss #137

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Update scss #137

merged 7 commits into from
Nov 21, 2024

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Oct 29, 2024

Checklist:

Closes #136

I also updated the spelling on some of the classes we were using.

Let me know if it's okay to delete some of the old SCSS variables. I think I managed to get all of them that mattered.

@a2937 a2937 requested a review from a team as a code owner October 29, 2024 23:48
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I ran this through the Discourse theme testing instance. It looks like we're not actually using the color_definitions.scss file?

@a2937
Copy link
Member Author

a2937 commented Nov 11, 2024

That's certainly odd. I'll double check the documentation and the main variable docs .

@a2937
Copy link
Member Author

a2937 commented Nov 11, 2024

Okay I fixed one error message. Time to fix the other one.

@a2937
Copy link
Member Author

a2937 commented Nov 11, 2024

Error: $color2: fcc-highlight-lightness-switch(#0088cc) is not a color. ╷ 14 │ $fcc-highlight-mid: mix($fcc-highlight-color, $fcc-highlight-background, 50%); │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ╵ /var/www/discourse/common.scss 14:21 root stylesheet

I think I only have a SCSS problem left.

@naomi-lgbt naomi-lgbt merged commit 144c13b into freeCodeCamp:main Nov 21, 2024
1 check passed
@a2937 a2937 deleted the chore/update-scss branch November 21, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using core SCSS color variables in themes is deprecated
2 participants