fix: remove flex from list controls #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this undoes the Alignment. I'd like to convince the Discourse team to merge the navbar PR before this gets merged. |
|
Maybe reaching out on meta.discourse.org should be the way forward? |
|
I did. https://meta.discourse.org/t/add-users-to-top-nav/63681/26 Beyond us reforking and updating our local version of the nav so I can add the content we need, I don't see a timely resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #144
In order to get our navbar aligned properly, we need a flexbox which
navigation-containerprovides. Thelist-controlsclass was used in multiple places so it's not an option sadly.And if I use
.clearfix, it'll mess with the topic rows.