Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standardize on "drive" for USB export devices #2251

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

cfm
Copy link
Member

@cfm cfm commented Oct 3, 2024

Status

Ready for review

Description

Addresses translators' feedback that referring to export "devices" (as opposed to "drives") is ambiguous, especially out of context.

This pull request is a proposal, on the grounds that it will take no more time to review this proposed solution than to talk about the problem it tries to solve. Feel free to close this or suggest alternatives.

Test Plan

@cfm cfm requested a review from a team as a code owner October 3, 2024 23:25
Copy link
Contributor

@deeplow deeplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on visual review and I have some additional places where I we could also apply this consistency.

  1. Should we also standardize the language in workstation.securedrop.org as a separate PR? I see that most references are already USB drive, but there are two instances of:

    • USB stick
    • USB devices
  2. Additionally, it's probably not user-facing, but I found two other non-code references to "USB devices":

Per feedback from Localization Lab that "device" is ambiguous out of
context.
@cfm
Copy link
Member Author

cfm commented Nov 28, 2024

Thanks, @deeplow. Done and rebased in 4ac928e for your re-review and merge.

@cfm cfm added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 7b27ddd Dec 3, 2024
58 checks passed
@cfm cfm deleted the standardize-on-drive branch December 3, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants