Migrate translation-tests to GitHub Actions #7222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translation tests are slow because it's our normal tests just run 20+ times, once for each language. We can use a dynamic matrix to generate separate jobs pretty easily (I learned this pattern from https://github.com/suzuki-shunsuke/example-github-actions-dynamic-matrix). This job is a little special as we only run it in specific circumstances. Two are easy to handle 1) branch filter and 2) scheduled run. But only triggering on PRs from "weblate-fpf" is a bit harder, so we add some run-time logic in the locales job itself.
legoktm
added a commit
to wikimedia/mediawiki-docker
that referenced
this pull request
Aug 18, 2024
I figured out this trick when working on SecureDrop (freedomofpress/securedrop#7222), we can dynamically generate the values for the matrix so we don't have to update them. That's not really a big burden anyways, but this is kind of cool.
legoktm
added a commit
to wikimedia/mediawiki-docker
that referenced
this pull request
Aug 18, 2024
I figured out this trick when working on SecureDrop (freedomofpress/securedrop#7222), we can dynamically generate the values for the matrix so we don't have to update them. That's not really a big burden anyways, but this is kind of cool.
legoktm
added a commit
to wikimedia/mediawiki-docker
that referenced
this pull request
Aug 18, 2024
I figured out this trick when working on SecureDrop (freedomofpress/securedrop#7222), we can dynamically generate the values for the matrix so we don't have to update them. That's not really a big burden anyways, but this is kind of cool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Translation tests are slow because it's our normal tests just run 20+ times, once for each language. We can use a dynamic matrix to generate separate jobs pretty easily (I learned this pattern from https://github.com/suzuki-shunsuke/example-github-actions-dynamic-matrix).
This job is a little special as we only run it in specific circumstances. Two are easy to handle 1) branch filter and 2) scheduled run.
But only triggering on PRs from "weblate-fpf" is a bit harder, so we add some run-time logic in the locales job itself.
Testing
pushpasses and runs full Translation jobspull requestruns locales job but skips Translation / test jobsDeployment
Any special considerations for deployment? n/a