-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove systemd-resolved, explicitly install systemd-hwe-hwdb on noble #7466
Conversation
Unfortunately this correctly installs systemd-resolved, but then that gets enabled and is actively running post-upgrade. So we need a postinst step to re-disable it. Will work on that tomorrow. |
51e15bf
to
7107b1d
Compare
This is going even more poorly; once we install systemd-resolved, it blows away /etc/resolv.conf, so when we turn it off, there's no DNS. Since DNS is configured by the admin, it's not something we can directly recreate (we could do the backup/restore strategy, like iptables). So I'm going to switch gears and just have us not install systemd-resolved. Unfortunately this invalidates our fresh install testing but I think it's going to work out better. |
7107b1d
to
c7bb893
Compare
We don't use systemd-resolved and during the focal -> noble migration, it gets dropped since it was split out to a separate package. Now that we can remove it entirely, let's have noble installs absent the package instead of merely stopping the systemd unit. Fixes #7464.
This package is installed on fresh systems, but not on upgrades because it was split out of the systemd package. Set the dependency ourselves to make sure it's always pulled in. Currently none of these udev rules apply to expected SecureDrop hardware, but it's good to futureproof ourselves just in case.
c7bb893
to
52106d9
Compare
It worked!! I can confirm that:
I didn't manually test a noble fresh install because staging CI does that for us, and it worked as expected:
|
Per release checkin meeting today, I will visually review, relying on CI + @legoktm 's prior testing. We will incorporate further testing as part of regular rc QA test plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've caught up with the context in #7464, the initial implementation plan, and the subsequent decision to remove systemd-resolved instead of installing everywhere, and I've reviewed the changes here- at first the systemd depends in the control file was slightly confusing given that context, but I see that it is conditionally pulling in the systemd-hwe-hwdb dependency for noble.
Thanks for all the documentation and for resolving this so quickly @legoktm - LGTM. Will look out for the backport.
Status
Ready for review
Description of Changes
These two packages are installed on fresh systems, but not on upgrades because they were split out of the systemd package.
Set the dependency ourselves to make sure it's always pulled in.[see discussion below]In the future once all SecureDrops are on noble, we can uninstall systemd-resolved entirely instead of merely stopping it.
Fixes #7464.
Testing
/etc/resolv.conf
points to your configured DNS, and e.g.curl https://securedrop.org
works since DNS is working../securedrop-admin install
works post-upgrade.Deployment
Any special considerations for deployment? upgrade is more important.