Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to include style HTML tags in citation span #196

Closed
grossir opened this issue Jan 30, 2025 · 0 comments
Closed

Try to include style HTML tags in citation span #196

grossir opened this issue Jan 30, 2025 · 0 comments
Assignees
@grossir

Comments

@grossir
Copy link
Contributor

grossir commented Jan 30, 2025 •
edited
Loading

See parent issue for description
grossir added a commit that referenced this issue Jan 30, 2025
@grossir
fix(annotate_citations): try to include HTML style tags if not balanced
39142e5 
Some annotations, specially for ReferenceCitations, are discarded in HTML sources because some style tags (mostly i or em) are not balanced. This PR tries to include the style tags in the citation span

- Adds tests for `utils.maybe_balance_style_tags`

Solves #196
@grossir grossir mentioned this issue Jan 30, 2025
Merged
grossir added a commit that referenced this issue Jan 30, 2025
@grossir
fix(annotate_citations): try to include HTML style tags if not balanced
ef078f6 
Some annotations, specially for ReferenceCitations, are discarded in HTML sources because some style tags (mostly i or em) are not balanced. This PR tries to include the style tags in the citation span

- Adds tests for `utils.maybe_balance_style_tags`
- Add a logger.error call when the unbalanced HTML could not be fixed

Solves #196
grossir added a commit that referenced this issue Jan 30, 2025
@grossir
fix(annotate_citations): try to include HTML style tags if not balanced
4bfcc46 
Some annotations, specially for ReferenceCitations, are discarded in HTML sources because some style tags (mostly i or em) are not balanced. This PR tries to include the style tags in the citation span

- Adds tests for `utils.maybe_balance_style_tags`
- Add a logger.error call when the unbalanced HTML could not be fixed

Solves #196
@grossir grossir moved this to In progress in Case Law Sprint Jan 30, 2025
@grossir grossir moved this from In progress to PR'd Issues 🤞 in Case Law Sprint Jan 31, 2025
@grossir grossir self-assigned this Feb 1, 2025
@grossir grossir closed this as completed Feb 5, 2025
@github-project-automation github-project-automation bot moved this from PR'd Issues 🤞 to Done in Case Law Sprint Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grossir grossir

Labels
None yet
Projects
Case Law Sprint
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grossir