fix(annotate_citations): try to include HTML style tags if not balanced #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grossir
force-pushed
the
196-include-html-style-tags-in-citation-span
branch
from
39142e5 to
ef078f6
Compare
Some annotations, specially for ReferenceCitations, are discarded in HTML sources because some style tags (mostly i or em) are not balanced. This PR tries to include the style tags in the citation span - Adds tests for `utils.maybe_balance_style_tags` - Add a logger.error call when the unbalanced HTML could not be fixed Solves #196
grossir
force-pushed
the
196-include-html-style-tags-in-citation-span
branch
from
ef078f6 to
4bfcc46
Compare
|
Unrelated to this specific PR, but, how to run the lint jobs locally? Shouldn't we have a |
The Eyecite Report 👁️Gains and LossesThere were 0 gains and 0 losses. Click here to see details.
Time Chart
Generated Files |
|
@flooie this is ready for review in case you want to review it or assign it to someone else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some annotations, specially for ReferenceCitations, are discarded in HTML sources because some style tags (mostly i or em) are not balanced. This PR tries to include the style tags in the citation span
utils.maybe_balance_style_tagsSolves #196