Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S2S-1727: ADD Magnite audiences aka carbon #177

Merged
merged 2 commits into from
Apr 17, 2024
Merged

S2S-1727: ADD Magnite audiences aka carbon #177

merged 2 commits into from
Apr 17, 2024

Conversation

ialex
Copy link

@ialex ialex commented Apr 16, 2024

Add files for carbonRtdProvider

@ialex ialex requested review from Barteezy and aecook April 16, 2024 15:51
@ialex ialex requested a review from a team as a code owner April 16, 2024 15:51
armando-fs
armando-fs reviewed Apr 16, 2024
View reviewed changes
Copy link

@armando-fs armando-fs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to update package.json to 8.40.1 as well?

@ialex
Copy link
Author

ialex commented Apr 16, 2024

Don't we need to update package.json to 8.40.1 as well?

we usually dont since this is the Prebid version from upstream

@ialex ialex requested a review from armando-fs April 16, 2024 22:40
@armando-fs armando-fs merged commit 2dc6ac6 into main Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armando-fs armando-fs armando-fs approved these changes

@Barteezy Barteezy Barteezy approved these changes

@aecook aecook Awaiting requested review from aecook

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ialex @Barteezy @armando-fs