fix: PFG-3233. Increasing minimum timeout to be not less than 1500 ms. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiAndrushkoFS
requested review from
martin-hill-freestar,
dmytroKononenkoFS,
AnatoliiBaidaFS,
anastasiiapankivFS and
pablomdorr
src/ajax.js
Outdated
| @@ -67,7 +67,9 @@ export function fetcherFactory(timeout = 3000, {request, done} = {}) { | |||
| let fetcher = (resource, options) => { | |||
| let to; | |||
| if (timeout != null && options?.signal == null && !config.getConfig('disableAjaxTimeout')) { | |||
| to = dep.timeout(timeout, resource); | |||
| const minTimout = 1500; | |||
| const normalizedTimeout = timeout > minTimout ? timeout : minTimout; | |||
There was a problem hiding this comment.
Probably we can simplify that:
Suggested change
| const normalizedTimeout = timeout > minTimout ? timeout : minTimout; | |
| const normalizedTimeout = Math.max(timeout, minTimout); |
There was a problem hiding this comment.
Thanx, that's a good option.
For me looks if I simplify it this way, then it would add the need to leave a comment to explain why we using Math.max to filter out too little timeout.
I would say original line looks more self explanatory
dmytroKononenkoFS
approved these changes
Jul 29, 2024
anastasiiapankivFS
approved these changes
Jul 30, 2024
aecook
requested changes
Jul 31, 2024
AndriiAndrushkoFS
deleted the
PFG-3233-requests-to-s2s-endpoint-getting-canceled-fix-V1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information