Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More mechanical sound support #466

Open
wants to merge 11 commits into
base: feature/sounds
Choose a base branch
from

Conversation

linojon
Copy link

@linojon linojon commented Jan 8, 2024

Work on the feature/sounds branch, continuing @Mr-Jay-Gatsby's work. For discussion up to this point, see #453

@linojon
Copy link
Author

linojon commented Jan 8, 2024

sorry 'bout all the commits, i like to do things in small increments when possible, and didnt squash the commits before creating the PR. Also the "Q to exit" isnt part of this feature, is a minor change for my convenience that i added to vpe-volley https://github.com/jsm174/vpe-volley/blob/sounds/Assets/Volley/Quitter.cs

@freezy
Copy link
Owner

freezy commented Jan 9, 2024

I've had a quick look at the previous code. About objects that aren't rendered but emit sounds: How about creating a new SoundEmitterComponent that implements ISoundEmitter and where you're basically able to define the sound triggers by yourself. Each of those triggers would then result in a coil slot that is linkable through the visual scripting (or anything that can connect to a coil, really).

This way, you'd create a chimes GameObject positioned in the scene, add the SoundEmitterComponent, add a trigger for each chime, and add a MechSoundsComponent which will show the triggers for you to assign sounds to. Then, in visual scripting, hook the score reels to the coils that are exposed.

@freezy
Copy link
Owner

freezy commented Jan 9, 2024

Oh, and also could you not commit the .mat files please? Those are unrelated to this PR and will result in conflicts later. And not remove the .meta files either, see https://github.com/freezy/VisualPinball.Engine/wiki/Development-Setup#meta-files

In general, never git commit -a, but choose the files that are relevant.

The number of commits doesn't matter, I prefer commits of small chunks too, but in this case I'd prefer if you'd squash or at least git rebase -i your commits to not have these changes in the history. Thanks!

@linojon
Copy link
Author

linojon commented Jan 30, 2024

ok, took a couple tries but i've rebased out the extraneous files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants