-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More mechanical sound support #466
base: feature/sounds
Are you sure you want to change the base?
Conversation
convenient especially prefabs.
sorry 'bout all the commits, i like to do things in small increments when possible, and didnt squash the commits before creating the PR. Also the "Q to exit" isnt part of this feature, is a minor change for my convenience that i added to vpe-volley https://github.com/jsm174/vpe-volley/blob/sounds/Assets/Volley/Quitter.cs |
I've had a quick look at the previous code. About objects that aren't rendered but emit sounds: How about creating a new This way, you'd create a chimes GameObject positioned in the scene, add the |
Oh, and also could you not commit the .mat files please? Those are unrelated to this PR and will result in conflicts later. And not remove the .meta files either, see https://github.com/freezy/VisualPinball.Engine/wiki/Development-Setup#meta-files In general, never The number of commits doesn't matter, I prefer commits of small chunks too, but in this case I'd prefer if you'd squash or at least |
b639bbe
to
d4834d0
Compare
d4834d0
to
89a8ab0
Compare
ok, took a couple tries but i've rebased out the extraneous files. |
Work on the feature/sounds branch, continuing @Mr-Jay-Gatsby's work. For discussion up to this point, see #453