Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bumper animations #489

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arthurkehrwald
Copy link
Contributor

Fixes the bumper animations broken in #483 . To be honest, I don't understand how this was working before. The delta time passed into the animation Update functions was the Unity frame time in milliseconds. But this was done in a loop that runs once for every millisecond of frame time. So the animations were just over before they could ever appear on screen. I also found it confusing how the physics engine uses seconds, milliseconds, and microseconds, often without the variable name indicating the unit used. (See #488)

@freezy
Copy link
Owner

freezy commented Nov 11, 2024

Thanks, I'll test this later tonight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants