wireguard-registration: on openwrt24.10 the https check prints to stderr #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grische
reviewed
Dec 15, 2024
| wget -q "https://[::1]" | ||
| if [ $? -eq 1 ]; then | ||
| ret=0 | ||
| wget -q "https://[::1]" 2>/dev/null || ret=$? |
There was a problem hiding this comment.
Why do you introduce the ret instead of having the original code?
There was a problem hiding this comment.
To make this passage more similar. We can of course also switch to the other way around or keep the difference.
Whatever you like better :)
There was a problem hiding this comment.
The || ret= is necessary if the script uses set -e and otherwise the old code is fine.
Just wondering if this additional complexity is worth it?
Error message is: SSL error: NET - Sending information through the socket failed The returncode behavior stays the same otherwise
maurerle
force-pushed
the
silence_https_check
branch
from
ee5bc04 to
a94dc26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We therefore pipe the output to /dev/null so that the below error message does not appear in
logreadoutput.The Error message is:
SSL error: NET - Sending information through the socket failedThe returncode behavior stays the same otherwise.