-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove respondd data which is not mesh relevant #1512
Conversation
8978a4f
to
52330e0
Compare
We can unify this code into a single provider used by both batadv and babel, but we can not remove it, as it is used by the status page. |
Also, when the providers are unified, the current data format generated by the batadv provider should be preserved for compatiblity. |
d589ba7
to
845a8b0
Compare
845a8b0
to
65a799d
Compare
Thats what i am working on freifunk-gluon/packages#188 |
@christf current state will remove |
As mentioned in freifunk-gluon/packages#188, I think this information should be moved to the gluon-respondd package. |
65a799d
to
8da243c
Compare
Just for cleanup, in first step only: freifunk-gluon/packages#217 enhancement comes later in: freifunk-gluon/packages#188 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything wifi-related has been purged from gluon-mesh-babel and gluon-mesh-batman-adv
@genofire Maybe you can refresh the PR to point out what I'm overlooking or close the PR to reflect it's done.
@@ -444,74 +444,6 @@ static struct json_object * get_traffic(void) { | |||
return ret; | |||
} | |||
|
|||
static void count_iface_stations(size_t *wifi24, size_t *wifi5, const char *ifname) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
count_iface_stations
has already been moved to respondd-neighbours.c in 0f1fa24
} | ||
} | ||
|
||
static void count_stations(size_t *wifi24, size_t *wifi5) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As well as count_stations
This PR is so much outdated and the subject is done. Maybe we make a new PR to remove it again, when we/i solve make that parts independent from gluon (without libgluonutils) by: |
What a great idea :P But thanks for closing it, highly appreciated. |
Those data should not be provided by mesh protocol packages.
(Most of them is duplicated)
DO NOT MERGE without Merge of freifunk-gluon/packages#188