Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

realtek-rtl838x: add support for D-Link DGS-1210-10P #2707

Merged
merged 2 commits into from
Dec 10, 2022
Merged

realtek-rtl838x: add support for D-Link DGS-1210-10P #2707

merged 2 commits into from
Dec 10, 2022

Conversation

AiyionPrime
Copy link
Member

@AiyionPrime AiyionPrime commented Nov 26, 2022 •
edited
Loading

as well as the target itself

  • Must be flashable from vendor firmware
    • Web interface (instructions are somewhat complex, not recommended)
    • TFTP
    • Other:
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())')
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging)
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
    • When re-adding a device that was supported by an earlier version of Gluon, a
      factory reset must be performed before checking the primary MAC address, as
      the setting from the old version is not reset otherwise.
  • Wired network
    • should support all network ports on the device (ports nine and ten sfp reportedly work in OpenWrt, but not tested)
    • must have correct port assignment (WAN/LAN)
      • On devices supplied via PoE, there is usually no explicit WAN/LAN labeling on the hardware.
        The PoE input should be the WAN port in this case.
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio
      • Should show activity
    • Switch port LEDs
      • Should map to their respective port (or switch, if only one led present)
      • Should show link state and activity
  • Outdoor devices only:
    • Added board name to is_outdoor_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
  • Docs:
    • Added Device to docs/user/supported_devices.rst

@github-actions github-actions bot added 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support labels Nov 26, 2022
@blocktrron
Copy link
Member

The target lacks USB support, so this package is not available, thus can not be dis- nor enabled.

Rename the line configuring this package in targets/generic to try_config

@AiyionPrime
Copy link
Member Author

That looks promising, thanks @blocktrron.
I'm currently a few hundred km from the switch; I think I'll get the next round of testing done till noon tomorrow.

@AiyionPrime AiyionPrime added the 5. needs: testing Testing of the changes is necessary label Nov 27, 2022
@AiyionPrime
Copy link
Member Author

Looks like that device does not support isolation either?
Tested this before @herbetom and I met in mumble on monday.
Can do the checklist tomorrow afternoon, but I'm starting to feel the need for an information-source/a script that can tell, whether this device is expected to do port isolation, or not...

#2679

@herbetom
Copy link
Contributor

but I'm starting to feel the need for an information-source/a script that can tell, whether this device is expected to do port isolation, or not...

It's actually relatively easy.

no isolation if one of the following applies:

  • unmaged switch ports
  • switch, but it's an target still configured via swconfig

In the following cases isolation is expected to work between all ports of that type and ports of other types:

  • DSA Switch Ports (happens on a per target base)
  • dedicated ports (like the ethernet on an APU)
  • VLANs

@AiyionPrime
Copy link
Member Author

Said switch is managed, realtek is DSA since 21.02.
At least in hannover this switch does not isolate bridgeports, but does when used with vlans instead.

@github-actions github-actions bot added the 3. topic: package Topic: Gluon Packages label Dec 1, 2022
@AiyionPrime
Copy link
Member Author

Everything except the reset button is working fine, was dropped as invalid in

openwrt/openwrt@61a3d00#diff-3fa215c7c9438012008b63350434341f8a2bc01b514837ecc11263e928822dd2L42-R49

I'll review his GPIO suspicion later...

@AiyionPrime AiyionPrime added 9. meta: upstream issue Issue pertains to an upstream project and removed 5. needs: testing Testing of the changes is necessary labels Dec 2, 2022
@AiyionPrime
Copy link
Member Author

Patch has been submitted.
https://patchwork.ozlabs.org/project/openwrt/patch/[email protected]/

@AiyionPrime AiyionPrime added 2. status: waiting-on-upstream Waiting for upstream changes and removed 2. status: waiting-on-upstream Waiting for upstream changes labels Dec 2, 2022
AiyionPrime and others added 2 commits December 9, 2022 16:32
@AiyionPrime @blocktrron
generic: try to not attempt to build kmod-usbip
e53308b 
targets without usb-support fail to build without this change

Co-authored-by: David Bauer <[email protected]>
@AiyionPrime
realtek-rtl838x: add support for D-Link DGS-1210-10P
a8dc234 
as well as the target itself
@AiyionPrime
Copy link
Member Author

Local testing is done, Buttons and LEDs work as intended.
Will be merged, once the actions are done.

@AiyionPrime AiyionPrime requested a review from rotanid December 10, 2022 11:32
@blocktrron blocktrron merged commit 4d61bc1 into freifunk-gluon:master Dec 10, 2022
@AiyionPrime AiyionPrime deleted the dgs-1210-10p branch December 10, 2022 18:30
@heini66
Copy link
Contributor

heini66 commented Dec 17, 2022 via email

@AiyionPrime
Copy link
Member Author

AiyionPrime commented Dec 17, 2022 •
edited
Loading

Good evening @heini66. You should avoid flashing Images onto devices that are not supported.

I'm out for tonight, but will look into the next steps for your device tomorrow.
Don't get you hopes up to early though; there are only few revisions supported by OpenWrt yet.
See you.

@AiyionPrime
Copy link
Member Author

If you can please provide a vendor link or a complete version string for your device.
I'm not sure

a 1210-24 rv d1

is really a thing.

@heini66
Copy link
Contributor

heini66 commented Dec 17, 2022 via email

@heini66
Copy link
Contributor

heini66 commented Dec 17, 2022 via email

@AiyionPrime
Copy link
Member Author

I think this would be the device you describe, not sure whether the developer or dlink introduced the two different names, sorry.

https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=b5bd945733a7ed235777c2ceaa0ff27dc779630f

The revsions F1 and F2 (and possibly newer ones newer as well) are supported by OpenWrt.
Your D1 has very likely a different SoC and is not.

https://wikidevi.wi-cat.ru/D-Link_DGS-1210-24_rev_A1

@AiyionPrime AiyionPrime mentioned this pull request Apr 18, 2023
Closed
21 tasks
@AiyionPrime AiyionPrime added the backport v2022.1.x Backport this pull request to v2022.1.x label Apr 20, 2023
@github-actions github-actions bot mentioned this pull request Apr 20, 2023
Merged
@github-actions
Copy link

Successfully created backport PR for v2022.1.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotanid rotanid Awaiting requested review from rotanid

Assignees
No one assigned
Labels
3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support 3. topic: package Topic: Gluon Packages 9. meta: upstream issue Issue pertains to an upstream project backport v2022.1.x Backport this pull request to v2022.1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AiyionPrime @blocktrron @herbetom @heini66