Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove old migrations #3406

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maurerle
Copy link
Member

v2023.2 did only support upgrades from v2022.x
we can therefore remove these old migrations for the next release

I hope, that I did not miss anything, but to me these were the only occurances of migrations to be deleted.

@github-actions github-actions bot added the 3. topic: package Topic: Gluon Packages label Dec 27, 2024
@rotanid
Copy link
Member

rotanid commented Dec 27, 2024

@maurerle please have a look at the linter error :)
package/gluon-core/luasrc/lib/gluon/upgrade/200-wireless:3:7: (W211) unused variable util

@maurerle maurerle force-pushed the remove_migrations branch 2 times, most recently from d4e1b11 to 1db3721 Compare December 28, 2024 09:55
@rotanid
Copy link
Member

rotanid commented Dec 28, 2024

i think it looks good now, but i would be more happy if @blocktrron or @neocturne decide about the merge

v2023.2 did only support upgrades from v2022.x
we can therefore remove these old migrations for the next release
@@ -223,11 +222,6 @@ wireless.foreach_radio(uci, function(radio, index, config)
uci:set('wireless', radio_name, 'legacy_rates', false)
configure_mesh_wireless(radio, index, config)
elseif (band == '5g') then
-- ToDo: Remove in v2024.x
local hostapd_options = uci:get_list('wireless', radio_name, 'hostapd_options')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This migration was added in 2023.1, I think it is too early to remove it.

@rotanid rotanid added the 2. status: waiting-on-author Waiting on some action from the author label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. status: waiting-on-author Waiting on some action from the author 3. topic: package Topic: Gluon Packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants