-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated implementation of query named parameters #169
base: 0.7.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Divi, thanks for opening this pull request, always happy about contributions 👍 👍
I really like the quality of this PR, just left a single remark below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for your work on this 👍
@Divi Thanks for looking into this, would love to get this in! The additional tests are much appreciated, definitely helps to get some certainty with this feature. It looks like some cases aren't covered right now, can you add some additional tests to ensure this works properly when using the same placeholder name multiple times ( |
Just to let you know, I've not forgotten you, I just don't have enough time for now but I keep in mind your request :) |
Hello!
I saw a previous pull request about the named parameters. Since there is no activity for 3 years now, I took the liberty to make my own implementation and update the unit tests.
It allows:
Of course, all the previous ways of querying still work.
I can update the README if needed.