Improve fsspec-proxy dependency groups #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| `%APPDATA%\pip\pip.ini` (on Windows) and add: | ||
|
|
||
| [global] | ||
| extra-index-url = https://pypi.anaconda.org/anaconda-cloud/simple |
There was a problem hiding this comment.
It's possible to add this as a command line arg, right?
There was a problem hiding this comment.
Hi @martindurant, thanks for the feedback, I added a 2nd method with the CLI argument.
fsspec-proxy/pyproject.toml
Outdated
Comment on lines
40
to
41
| "s3fs", | ||
| "anaconda-cloud-storage" |
There was a problem hiding this comment.
I think you can make these relative to the other groups
Suggested change
| "s3fs", | |
| "anaconda-cloud-storage" | |
| ".[s3]", | |
| ".[anaconda]" |
so that if the other groups change, we don't have to edit in two places.
There was a problem hiding this comment.
Unfortunately, we got a syntax error with this. I like the idea though, so I used the brand new PEP735 dependency groups feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a little time to figure out why I was getting a Filesystem Initialization error. This PR updates the README and the dependency group names to make things more clear.