Refactor builtin Sig into TypeRepr
#250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have two indications of a builtins type: - `Sig i o`, which just provided the arity - `BuiltinType i`, which is a closure that checks the type However, since `Sig` just indicates the arity, it doesn't give us quite enough information to render the capabilities doc as described in #224. In this refactor, I extended `Sig` to `TypeRepr` and made it hold more information: an actual deep embedding of the types. I also moved this new type into `BuiltinType` (which is now a record). This allows convenient construction of _both_ `TypeRepr` and the checker closure using `🡒` and `out`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have two indications of a builtins type:
Sig i o, which just provided the arityBuiltinType i, which is a closure that checks the typeHowever, since
Sigjust indicates the arity, it doesn't give us quite enoughinformation to render the capabilities doc as described in #224.
In this refactor, I extended
SigtoTypeReprand made it hold moreinformation: an actual deep embedding of the types. I also moved this new type
into
BuiltinType(which is now a record). This allows convenient constructionof both
TypeReprand the checker closure using🡒andout.