Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tui): add Hindi (hi) locale #1343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(tui): add Hindi (hi) locale #1343

wants to merge 1 commit into from

Conversation

fujiapple852
Copy link
Owner

No description provided.

@kiranyele18
Copy link

Could you please assign me hindi issue to me @fujiapple852, I would love to contribute.

@fujiapple852
Copy link
Owner Author

Thanks @kiranyele18 !

@kiranyele18
Copy link

could you explain how to merge changes? @fujiapple852

@c-git
Copy link
Collaborator

c-git commented Nov 8, 2024

could you explain how to merge changes? @fujiapple852

Do you mean the changes that you made? Did you clone the repo to do them?

@kiranyele18
Copy link

could you explain how to merge changes? @fujiapple852

Do you mean the changes that you made? Did you clone the repo to do them?

The changes that made by me. And fork the repo in github made changes and pull the request but not submitted yet. @fujiapple852

@c-git
Copy link
Collaborator

c-git commented Nov 8, 2024

Thank you, I see the pull request that you created. #1378 . We'll review it and get back to you, thank you very much.

@fujiapple852 fujiapple852 force-pushed the feat-i18n-hi branch 2 times, most recently from 1e4a9a0 to c7d6ac1 Compare November 15, 2024 10:16
@@ -1098,6 +1197,7 @@ column_dprt:
ru: "Назн"
es: "Dprt"
de: "Dprt"
hi: "गंतव्य पोर्ट"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiranyele18 can this be abbreviated to a single word (no spaces)?

@@ -1087,6 +1185,7 @@ column_sprt:
ru: "Исх"
es: "Sprt"
de: "Sprt"
hi: "स्रोत पोर्ट"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiranyele18 can this be abbreviated to a single word (no spaces)?

@@ -1022,6 +1114,7 @@ column_stdev:
ru: "СКО"
es: "DesvE"
de: "StdAbw"
hi: "मानक विचलन"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiranyele18 can this be abbreviated to a single word (no spaces)?

@@ -1011,6 +1102,7 @@ column_wrst:
ru: "Худ"
es: "Peor"
de: "Schlechteste"
hi: "सबसे खराब"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiranyele18 can this be abbreviated to a single word (no spaces)?

@fujiapple852
Copy link
Owner Author

@kiranyele18 (cc @c-git) thank you for your contribution! I've taken all of your changes from #1378 and applied them here, the only change I made was to leave the technical terms (TCP/UDP etc) as English.

The only issue I see is the column names that have spaces, I've opened specific threads about finding abbreviations for those.

Here is how it currently looks:

Screenshot 2024-11-15 at 6 23 39 PM Screenshot 2024-11-15 at 6 23 19 PM Screenshot 2024-11-15 at 6 22 53 PM Screenshot 2024-11-15 at 6 22 38 PM

@fujiapple852 fujiapple852 mentioned this pull request Nov 15, 2024
@fujiapple852
Copy link
Owner Author

@kiranyele18 can you comment on the open threads? They all relate to having spaces in column names, which we'd like to avoid.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants