Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI #76

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Add CI #76

merged 2 commits into from
Dec 14, 2024

Conversation

JohannesLorenz
Copy link
Collaborator

This PR has 2 commits:

  1. First commit by you, from the old ci-test branch, modernizes the CMakeLists. Since you wrote this commit and I already checked it, you do not neccessarily need to review it.
  2. Second commit is by me, introducing the CI.

Can you please review it? Thanks on advance.

@fundamental
Copy link
Owner

Looks good overall, just a few clarification comments/questions.

@JohannesLorenz @fundamental
Add Github Actions CI
6d903b2 
Co-authored-by: fundamental <[email protected]>
@JohannesLorenz JohannesLorenz merged commit c33ad42 into master Dec 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fundamental fundamental fundamental left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesLorenz @fundamental