Style syntax matching: Class, Name, Resource, Icon, WindowID #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasAdam
force-pushed
the
ta/stylev3
branch
from
a9b0f87 to
15dc522
Compare
ThomasAdam
added
the
type:breaking
ThomasAdam
force-pushed
the
ta/stylev3
branch
6 times, most recently
from
d134ba2 to
75a6de5
Compare
ThomasAdam
force-pushed
the
ta/stylev3
branch
from
eade2d6 to
d2c7d52
Compare
ThomasAdam
force-pushed
the
ta/stylev3
branch
2 times, most recently
from
3c0ed9d to
05de703
Compare
Historically, window style matching relied on fvwm matching a window's name or resource or class, etc., in a hard-coded order, with very little means of being able to specify those properties. With this change, it's now possible to specify the following attributes a window should match against, either individually or in combination: - Resource - Class - Name - Icon - WindowID For example: Style (Name foo, Class XTerm) Sticky Would only make the window sticky if its name matched "foo", and its class is "XTerm". Existing style lines such as: Style foo Sticky Still work as expected. In addition, this change also removes the "PrintInfo style" command as it is no longer useful with this change to styles.
ThomasAdam
force-pushed
the
ta/stylev3
branch
from
05de703 to
02ca045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, there was always a demand to do something radical with Styles. This change takes a small step to that by conditionally including matches on a window for its:
(WM_NAME)(WM_CLASS)(WM_CLASS)Hence with this change it's now possible to do:
Here, if a window whose Class matches XTerm, AND its Name matched FvwmPrompt, then it would be started shaded.
If any other window just had a name/class/resource of XTerm, then it would be started iconic.