Add packed/aligned quat types #1353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZXShady
reviewed
Mar 22, 2025
| @@ -200,6 +200,46 @@ static int test_copy_vec3() | |||
| return Error; | |||
| } | |||
|
|
|||
| static int test_copy_quat() | |||
There was a problem hiding this comment.
this could be made into a templated function
There was a problem hiding this comment.
For sure! I was trying to follow what seemed to be the prevailing style in the tests, but happy to remove some duplication if that's desired.
There was a problem hiding this comment.
the previaling style in most of glm is not that great tbh.
In my pr I removed 7600~ lines of code and replaced them with just 2600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our projects we use aligned types by default, but in some data structures have a need for a tightly-packed quaternion to avoid padding. We're defining our own typedef at the moment, but seems like a nice thing to have in the library itself.
Not sure if there are any concerns about pulling in
gtc/quaternion.hpptogtc/type_aligned.hpp; I see it's not the first additional GTC header anyway. Happy to consider alternatives if it isn't desired, though.Add
aligned*_quatandpacked*_quattypdefs mirroring vectors, and a new test togtc_type_aligned.cpp.